search

ralmsdeveloper / EntityFrameworkCore.FirebirdSQL

FirebirdSQL database provider for Entity Framework Core.
Other
44 stars 26 forks source link

OFFSET and FETCH NEXT clauses #20

Closed thelostcode closed 6 years ago

thelostcode commented 6 years ago

The issue

OFFSET and FETCH FIRST Clauses are not supported by Firebird.

However the base implementation of Linq generates them to the end on Queries if you do

Table
   .OrderBy(...)
  .Skip(Any)
  .Take(Any)

This results in a statement that cannot be executed.

Do you have an idea where Entity Framework Core generates this? I am willing to implement it correctly.

thelostcode commented 6 years ago

Alright. I found it out. Closing this as I will send you a couple of PR's in a few.

thelostcode commented 6 years ago

Well, could you just cherry pick this one to master?

https://github.com/thelostcode/EntityFrameworkCore.FirebirdSQL/commit/4ea167820d9c22c13080337cb886f5b7282547db

ralmsdeveloper commented 6 years ago

I'll look at this tomorrow, thank you!

ralmsdeveloper commented 6 years ago

Adjusted!