Changes for first NAG pull request

[talassio]

==================================

Changes required to compile with nagfor

ral_nlls_internal.f90

• Fixed wrong intent for X in calculate_step
• Remove short-circuit evaluation in mult_J and mult_Jt and matmult_inner

• Add default value for status (intent=out) in evaltensor_f and evaltensor_J and evaltensor_HF

  ral_nlls_workspaces.f90

• Set the right type/size for A and ew in setup_workspace_all_eig_symm

  example_module.f90

  • Fix wrong intent for f in eval_F and eval_F_error inout => out

[codecov-io]

Codecov Report

Merging #15 into master will decrease coverage by 0.42%. The diff coverage is 76.84%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   91.42%   90.99%   -0.43%     
==========================================
  Files           3        3              
  Lines        2215     2255      +40     
==========================================
+ Hits         2025     2052      +27     
- Misses        190      203      +13

Impacted Files	Coverage Δ
libRALFit/src/ral_nlls_ciface.f90	80.92% <0%> (-1.71%)	:arrow_down:
libRALFit/src/ral_nlls_workspaces.f90	88.66% <46.8%> (-0.46%)	:arrow_down:
libRALFit/src/ral_nlls_internal.f90	93.43% <89.85%> (-0.24%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b59abc...e33f752. Read the comment docs.

[tyronerees]

All looks good, as per telephone conversation of 1/3/19

I'm going to open an issue to tidy up the cmake file to that this can be compiled with nagfor using just FCC=nagfor

Thanks, Andrew!