search

ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

set records by incrementing #42

Closed tyronerees closed 5 years ago

tyronerees commented 5 years ago

Instead of using hard coded rec(*)'s, change so that a variable is incremented. This makes it easier to add new options at the appropriate place in the code (as all the numbers don't have to be modified by hand), and avoids issues where an index has been skipped, leading to undefined output being printed.

This fixes #40

tyronerees commented 5 years ago

@talassio : could you please check that you agree this is a sensible thing to do?

codecov-io commented 5 years ago

Codecov Report

Merging #42 into master will increase coverage by 0.32%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   84.41%   84.73%   +0.32%     
==========================================
  Files           4        4              
  Lines        2566     2621      +55     
==========================================
+ Hits         2166     2221      +55     
  Misses        400      400
Impacted Files Coverage Δ
libRALFit/src/ral_nlls_printing.f90 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9f438c...b175615. Read the comment docs.