search

ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

`norm_S_d` undefined under some option combinations #44

Closed talassio closed 3 years ago

talassio commented 5 years ago

This is an analogous issue to the undefined nord_2_d issue in calculate_step and is solved in the box-logic branch.

Symptom: norm_S_d has intent OUT yet it can be undefined under certain conditions.

https://github.com/ralna/RALFit/blob/2b0dfc8bb9d34e8d1c302842964afa951bcfcacb/libRALFit/src/ral_nlls_internal.f90#L1052 Change to

    norm_2_d = 1.0e10_wp ! set norm_2_d so that it can't be undefined later
    norm_S_d = 1.0e10_wp ! set norm_S_d so that it can't be undefined later