ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

Wrong count of Hessian evaluations #45

Closed talassio closed 3 years ago

talassio commented 5 years ago

Symptom: Routine get_Hi does not account for the calls made to eval_HF. This issue is solved in the box-logic branch.

Solution: Update inform%h_eval.

       if ( present(weights) ) then
          call eval_HF(inform%external_return, n, m, X, weights(1:m)*ei, Hi, params)
       else
          call eval_HF(inform%external_return, n, m, X, ei, Hi, params)
       end if
       inform%h_eval = inform%h_eval + 1
       If (inform%external_return/=0) Then
         inform%status = NLLS_ERROR_FROM_EXTERNAL
         inform%external_name = "eval_HF"
       End iF
     end subroutine get_Hi
talassio commented 5 years ago

Added separate ledger for eval_hp. Now box-logic branch has 4 counters, and print_bye, reports them on high print_levels.