search

ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

Update to recovery logic (from box-logic branch) #54

Closed talassio closed 5 years ago

talassio commented 5 years ago

Recovery must take into account the two scenarios where user call-backs are faulty: 1) eval_?_status is non-zero 2) vector or matrix returned is unusable (this check generally occurs at a later point that the previous one.

Two major updates to address the previous point:

1) eval_f_status now also updates num_successful_steps = 0 2) added checks to normfnew 3) success of TR loop only happens if eval_J_status is zero, this requires to add new check on normJFnew 4) check normJFnew in reset_gradients

codecov[bot] commented 5 years ago

Codecov Report

Merging #54 into master will decrease coverage by 0.23%. The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   88.53%   88.29%   -0.24%     
==========================================
  Files           4        4              
  Lines        2668     2683      +15     
==========================================
+ Hits         2362     2369       +7     
- Misses        306      314       +8
Impacted Files Coverage Δ
libRALFit/src/ral_nlls_internal.f90 90.63% <77.14%> (-0.4%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ba945b...ad31741. Read the comment docs.