search

ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

Setup workspace routines clear inform derive type #57

Closed talassio closed 3 years ago

talassio commented 5 years ago

@tyronerees The routines setup_workspace* have inform with intent(Out) resetting to default values each time they are called, this is not the desired behaviour under the new fallback strategy, where some workspaces are not yet available and setup_workspace* is called and hence clears inform, rationales is to keep NLLS_SOLVE with intent(Out) for inform and all other routines change to intent(InOut).

Affects

setup_workspace_aint_tr.f90
setup_workspace_all_eig_symm.f90
setup_workspace_calculate_step.f90
setup_workspace_dogleg.f90
setup_workspace_evaluate_model.f90
setup_workspace_generate_scaling.f90
setup_workspace_max_eig.f90
setup_workspace_min_eig_symm.f90
setup_workspace_more_sorensen.f90
setup_workspace_regularization_solver.f90
setup_workspace_solve_general.f90
setup_workspace_solve_lls.f90
setup_workspace_solve_newton_tensor.f90
setup_workspaces.f90
talassio commented 5 years ago

Fixed in box-logic in commit 88de268849df5c7c3bb2cf4ffc69e16fb569ae4e