Closed talassio closed 3 years ago
Merging #60 into master will decrease coverage by
5.46%
. The diff coverage is90.01%
.
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 88.22% 82.76% -5.47%
==========================================
Files 4 6 +2
Lines 2692 3568 +876
==========================================
+ Hits 2375 2953 +578
- Misses 317 615 +298
Impacted Files | Coverage Δ | |
---|---|---|
libRALFit/src/ral_nlls_internal.f90 | 81.47% <ø> (-9.17%) |
:arrow_down: |
libRALFit/src/ral_nlls_ciface.f90 | 81.50% <75.32%> (-0.03%) |
:arrow_down: |
libRALFit/src/nag_export_mod.f90 | 82.50% <82.50%> (ø) |
|
libRALFit/src/ral_nlls_workspaces.f90 | 79.39% <82.79%> (+0.42%) |
:arrow_up: |
libRALFit/src/ral_nlls_bounds.f90 | 87.80% <87.80%> (ø) |
|
libRALFit/src/ral_nlls_printing.f90 | 97.94% <97.81%> (-2.06%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update def0291...a8b927b. Read the comment docs.
I don't know what the issue would be, but just to note that the python test fails on my system with these changes:
===========================
=--Testing the main file--=
===========================
*** All (main) tests passed successfully! ***
=============================
=--Testing the subroutines--=
=============================
*** All (helper) tests passed successfully! ***
**************************************
*** All tests passed successfully! ***
**************************************
Note: The following floating-point exceptions are signalling: IEEE_UNDERFLOW_FLAG IEEE_DENORMAL
STOP 0
** C test passed successfully **
3c3
< The cost function is 0.000000 at the minimum, and ||J^Tr||=2.247131e+00
---
> The cost function is 2.247131 at the minimum, and ||J^Tr||=4.097987e-06
[Python test]: Something is wrong with the diff
Interesting that the C and Fortran tests passed...hopefully this will change naturally when python is properly hooked in
This merge adds the memory allocation corrections that are in master. There were merge conflicts, but (hopefully!) they were resolved straightforwardly
This PR: fixes #43 fixes #44 fixes #45 fixes #57 fixes #65 fixes #72 fixes #76 fixes #79 fixes #90