search

ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

use any(), not maxloc(), to ensure portability #7

Closed tyronerees closed 5 years ago

tyronerees commented 5 years ago

Fixes #5

The code used maxloc() with a mask on the real part to find if all was complex -- in gfortran this return 0 if the mask is all false. ifort returns 1 in this case, though, so switch to using any() to check for any .true. in the logical array

codecov-io commented 5 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files           3        3           
  Lines        2215     2215           
=======================================
  Hits         2025     2025           
  Misses        190      190
Impacted Files Coverage Δ
libRALFit/src/ral_nlls_internal.f90 93.67% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c557b47...27eb62c. Read the comment docs.