search

ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

Tensor-Newton subproblem non-zero exit `tensor_inform%status` #72

Closed talassio closed 3 years ago

talassio commented 4 years ago

If Tensor-Newton sub-problem fails (solved via recursive call to nlls_iterate the tensor_inform%status is not propagated to inform%status, actually, tensor_inform%status is only used to break the iteration loop and is never propagated! see here

Proposed fix is to add a check and propagate on non-zero exit status after calling nlls_finalize.

The proposed change aligns with the current behaviour of all other sub-problems in the allow_fallback scheme.

NOTE: This change induces hard exit (no_progress_x error) of (outer) calculate_step due to (inner) calculate_step non-zero exit status.

talassio commented 4 years ago

Commit 2859785cef7fadd36fa4331053e00f792c15d8f0 Fixes #72 @tyronerees please review and if possible close issue #72