ralna / RALFit

A non-linear least squares solver
Other
25 stars 6 forks source link

83 fix params #84

Closed tyronerees closed 4 years ago

tyronerees commented 4 years ago

Fixes #83. @talassio -- could you please take a look at this to check you're happy?

Running BoxLanczos gives a slightly different answer (and takes a few more iterations). The iterations start to diverge at iteration 54, and are identical before that, so I assume it's a weird numerical issue and not something seriously wrong (but please check, just in case I've missed something!).

This branch seems to have picked up some documentation updates that aren't currently in the box-logic branch. I'll fix the docs for this when I get to the docs generally -- I haven't touched them here.

codecov[bot] commented 4 years ago

Codecov Report

Merging #84 into box-logic will decrease coverage by 5.25%. The diff coverage is 93.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##           box-logic      #84      +/-   ##
=============================================
- Coverage      88.29%   83.03%   -5.26%     
=============================================
  Files              4        6       +2     
  Lines           2682     3472     +790     
=============================================
+ Hits            2368     2883     +515     
- Misses           314      589     +275
Impacted Files Coverage Δ
libRALFit/src/ral_nlls_internal.f90 81.38% <ø> (-9.25%) :arrow_down:
libRALFit/src/ral_nlls_ciface.f90 85% <100%> (+3.46%) :arrow_up:
libRALFit/src/nag_export_mod.f90 82.5% <82.5%> (ø)
libRALFit/src/ral_nlls_workspaces.f90 79.58% <84.21%> (+0.38%) :arrow_up:
libRALFit/src/ral_nlls_bounds.f90 87.8% <87.8%> (ø)
libRALFit/src/ral_nlls_printing.f90 97.94% <97.81%> (-2.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dece9fc...3cb5a58. Read the comment docs.