95 fix cjac

[talassio]

WORK IN PROGRESS

Updates related to options%Fortran_Jacobian

This branch closes #95

This is the first proposal to update parts of the code that handle Matrix-Vector Products or other related operations pertaining to the Jacobian (only for the case where it is provided as Jacobian Transpose via row-major, using the option options%Fortran_Jacobian = .False.)

• Forces mult_J and mult_Jt to specify the leading dimension of J, the optional parameter options is replaced by a mandatory lofical parameter Fortran_Jacobian

• evaltensor_f and evaltensor_J require to know the leading dimension of J and for that tensor_params type is extended with a new node Fortran_Jacobian that is set at the entry of the recursive call to nlls_iterate in solve_newton_tensor()

• evaltensor_J now branches on the Jacobian's leading dimension

• Numerical artifacts should be kept minimal, initial test shows rubbish creping arount 10^-7 for the Lanczos3 example with default options

• Add a mandatory logical flag to solve_LLS so to consider the leading dimension of the Jacobian.

• Add a test to make sure the LLS is solving the right problem

Missing test to be added

• [x] test evaltensor_J and check that it returns the correct array for params%extra=0,1,2 and params%Fortran_Jacobian=T/F
• [x] Full code-path tests should be duplicated with opt%Fortran_Jacobian = T/F and compared.

[codecov[bot]]

Codecov Report

Merging #97 (7e67d6e) into master (bf8cf69) will decrease coverage by 0.08%. The diff coverage is 80.70%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   82.67%   82.58%   -0.09%     
==========================================
  Files           6        6              
  Lines        3624     3635      +11     
==========================================
+ Hits         2996     3002       +6     
- Misses        628      633       +5     

Impacted Files	Coverage Δ
libRALFit/src/ral_nlls_internal.f90	81.41% <80.35%> (-0.15%)	:arrow_down:
libRALFit/src/ral_nlls_workspaces.f90	79.42% <100.00%> (+0.03%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf8cf69...3b767e2. Read the comment docs.