search

ralna / spral

Sparse Parallel Robust Algorithms Library
https://ralna.github.io/spral/
Other
102 stars 27 forks source link

[CI] Precompile SPRAL when a new release is tagged #186

Closed amontoison closed 6 months ago

amontoison commented 6 months ago

close #175

@jfowkes This action should automatically create a new release of GitHub with precompiled binaries for you. It means that you ONLY need to tag the last commit on the branch master to trigger the action.

git checkout master
git tag <tagname>
git push origin --tags

<tagname> must have a v as first character like v1.0.0 or v2024.1.17.

amontoison commented 6 months ago

It's not working yet. I have a small error on my fork. Do not merge yet please.

amontoison commented 6 months ago

Update: The error was because the url of the repository was wrong for my fork (see here). I tested on the branch master of my fork and it seems to work: https://github.com/amontoison/spral/actions/runs/7558550254/job/20580334459

I have the new release on my fork :+1: https://github.com/amontoison/spral/releases/tag/v2024.1.17

Update2: Ready to be merged. :rocket:

jfowkes commented 6 months ago

@amontoison I'm afraid that the action failed 😢 https://github.com/ralna/spral/actions/runs/7567182833/job/20605856901 It created a new release but failed to upload the precompiled binaries.

amontoison commented 6 months ago

The issue is the tag of the release. You did 2024.01.18 but the version number doesn't include the 0 of the month of January so he tried to upload archives with 2024.1.18.

jfowkes commented 6 months ago

As you can see from past releases, the version numbers always include the zero!

amontoison commented 6 months ago

Ok, so I need to modify the file release.yml to handle this case.

amontoison commented 6 months ago

After #187, you just need to force the tag (same commands with -f) on the new commit. I hope that it will work now 🤞