Fix continuous integration - Githubissues

ralna / spral

Sparse Parallel Robust Algorithms Library

https://ralna.github.io/spral/

Other

105 stars 27 forks source link

Fix continuous integration #192

Closed amontoison closed 5 months ago

amontoison commented 5 months ago

Update the build for Apple Silicon.

cc @jfowkes

jfowkes commented 5 months ago

@amontoison this currently breaks the macOS tests, any idea why or how to fix?

amontoison commented 5 months ago

@amontoison this currently breaks the macOS tests, any idea why or how to fix?

The issue is related to new headers in Xcode. Can you try to compile SPRAL on your computer?

jfowkes commented 5 months ago

@amontoison can we switch to using homebrew for the macOS meson tests (see auto tools.yml)and install openblas and hwloc that way? The macOS meson tests are failing because openblas is not being found.

jfowkes commented 5 months ago

@amontoison the other macOS test are failing on the following GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114007 We will have to wait until GCC 13.3 is available before merging this PR.

amontoison commented 5 months ago

@amontoison can we switch to using homebrew for the macOS meson tests (see auto tools.yml)and install openblas and hwloc that way? The macOS meson tests are failing because openblas is not being found.

@jfowkes I don't see this issue with CI builds. It seems that GitHub Actions also switched to Apple Silicon for Mac builds. Maybe we should not use macos-latest but an older one, what do you think?

jfowkes commented 5 months ago

@amontoison yeah it's a right mess, can we switch back to macos-13? And the same for CIrrus (whatever they call macOS 13)?

jfowkes commented 5 months ago

@amontoison FYI macOS versions:

Monterey == 12
Ventura == 13
Sonoma == 14

amontoison commented 5 months ago

Using MacOS ventura fixed the issue with CirrusCI. I think that Monterey was removed and they installed MacOS Sonoma as fallback.

jfowkes commented 5 months ago

Okay so guess we should use Ventura (13) for autotools.yml and meson.yml?

amontoison commented 5 months ago

@jfowkes The flag -Wl,-ld_classic that you added fixes the issue in autotools.yml. We need to add it in the Meson build system.

jfowkes commented 5 months ago

@amontoison sure just do:

-Dfortran_link_args='-Wl,-ld_classic'

should be correct according to the Meson docs.

amontoison commented 5 months ago

@jfowkes All tests passes :tada: :tada: You probably need to do the same modifications in the other GitHub repositories of ralna (GALAHAD, ArchDefs, CUTEst).

jfowkes commented 5 months ago

@amontoison yes Nick is struggling with fixing the GALAHAD CI and could use some help!