Closed mjacobse closed 1 month ago
Thanks @mjacobse, what a mess. It's not clear to me what the correct setting should be here.
@nimgould any ideas on what was intended here?
@nimgould says that the documentation is incorrect and the code is correct so it should be match(m)
in the docs.
Yeah that makes sense. On further inspection, the only memory issues I can find when using m
are with singular matrices and special cases of #200, so we can discuss and handle those there.
Documentation says
match(n)
(auction_scale_unsym, hungarian_scale_unsym), code saysmatch(m)
(auction_scale_unsym_int32, auction_scale_unsym_int64, hungarian_scale_unsym_int32, hungarian_scale_unsym_int64).The tests pass an oversized
match(maxn)
withm, n <= maxn
and the examples are using a square matrix, so they do not really provide clarification either.Indeed, neither
match(m)
normatch(n)
seem to work correctly in all cases. For both there are settings with eitherm < n
orm > n
that lead to memory access violations or uninitialized returned values.