PHP 8 + PHPUnit 9.4 - Githubissues

ralouphie / mimey

PHP package for converting file extensions to MIME types and vice versa.

MIT License

324 stars 87 forks source link

PHP 8 + PHPUnit 9.4 #24

Closed rodber closed 3 years ago

rodber commented 4 years ago

Hi,

This one adds support for PHP 8 and PHPUnit 9.4. I had to drop support for 5.4.

Tested locally with 7.4 + 8.0. Travis passing.

Xantios commented 3 years ago

Can someone please merge this so I can pull this down from packagist ?:-) Thanks !

peter279k commented 3 years ago

pin @ralouphie.

dmyers commented 3 years ago

I'm wondering if this is even maintained anymore. The last commit to develop was from March 2019.

Xantios commented 3 years ago

I'm wondering if this is even maintained anymore. The last commit to develop was from March 2019.

I Assumed the same. so i forked this repo and made sure it works in PHP 8. https://github.com/xantios/mimey

I just added a custom VCS entry to my composer file, but if there is any interest I can push it to packagist

peter279k commented 3 years ago

Pin @ralouphie.

pvsaintpe commented 3 years ago

@ralouphie, @rodolfoberrios

We really need support in our project:

php: ^8.0
phpunit/phpunit: ^9.5
php-coverals: ^2.0

When can we expect a release with these changes? I really don't want to make forks and other crutches ..

Thank you in advance.

rodber commented 3 years ago

@pvsaintpe

I just contributed a few lines, I'm not the maintainer of this project. It seems that the person in charge isn't around, and likely it won't appear if you just keep mention this issue. Please don't push, it doesn't bring anything constructive imo. It will sound harsh, but if you really need this so bad then consider to fork it and maintain it. Otherwise you will be fall in the same situation with other maintainers not matching your release schedule requirements.

vedro-compota commented 3 years ago

@ralouphie this needed

vedro-compota commented 3 years ago

Guys we need some fork or does anyone have contact of the Author? @Xantios yes, packagist for this pack is needed too, because of recurs. dependencies.

rodber commented 3 years ago

I'm done, sorry.

Xantios commented 3 years ago

Guys we need some fork or does anyone have contact of the Author? @Xantios yes, packagist for this pack is needed too, because of recurs. dependencies.

You can add a VCS entry to your composer file and pull my fork in. If there are more people wanting to maintain it, feel free to PR on that fork I will setup some composer stuff around it later today

Xantios commented 3 years ago

@rodolfoberrios No worries! 👍 Thanks for figuring this out! @vedro-compota Check out my fork on https://github.com/xantios/mimey

For all, if you want to PR something, feel free to PR my fork 👍

peter279k commented 3 years ago

@rodolfoberrios No worries! Thanks for figuring this out! @vedro-compota Check out my fork on https://github.com/xantios/mimey

For all, if you want to PR something, feel free to PR my fork

@Xantios, thanks a lot!

peter279k commented 3 years ago

@Xantios, BTW, could you create the issue on your forked repository?

Xantios commented 3 years ago

@Xantios, BTW, could you create the issue on your forked repository?

The issue (PHP 8 / PHPUnit 9.4 support) is already merged in on the fork :-)

peter279k commented 3 years ago

@Xantios, BTW, could you create the issue on your forked repository?

The issue (PHP 8 / PHPUnit 9.4 support) is already merged in on the fork :-)

Sorry. I mean could you enable issue setting on your forked repository?

You can enable the issue like following picture:

Xantios commented 3 years ago

Done! @peter279k

Radon8472 commented 2 years ago

You should remove

protected function setUp(): void

From you PR, this breaks compatibility to older php versions