search

ralph-irving / squeezelite

Lightweight headless squeezebox player for Lyrion Media Server
https://sourceforge.net/projects/lmsclients/files/squeezelite/
Other
386 stars 98 forks source link

unhandled grfe #219

Closed barrelltitor closed 3 months ago

barrelltitor commented 5 months ago

Hey! I'm using squeezelite on a Raspberry Pi 4B+ in a docker container from here

When squeezelite starts, there's a lot of spam with unhandled grfe. I haven't found anything online about this.

image As you can see by the log line, this happens thousands of times. Squeezelite does work fine though, so I'm not sure what the actual issue is.

The warning seems to come from here

debug logs:

2024-04-07T11:58:03.398672816Z [11:58:03.398034] process_strm:280 strm command t
2024-04-07T11:58:03.398824273Z [11:58:03.398167] sendSTAT:195 STAT: STMt
2024-04-07T11:58:03.399184478Z [11:58:03.398785] process:532 unhandled grfe

sdebug logs:

2024-04-07T12:02:41.501372292Z [12:02:41.441918] process:528 strm
2024-04-07T12:02:41.505812044Z [12:02:41.505287] process_strm:280 strm command t
2024-04-07T12:02:41.505976782Z [12:02:41.505437] sendSTAT:171 ms_played: 0
2024-04-07T12:02:41.506018501Z [12:02:41.505480] sendSTAT:195 STAT: STMt
2024-04-07T12:02:41.506371466Z [12:02:41.505593] sendSTAT:198 received bytesL: 0 streambuf: 0 outputbuf: 0 calc elapsed: 0 real elapsed: 449259932 (diff: -449259932) device: 0 delay: 449259932
2024-04-07T12:02:41.507327968Z [12:02:41.506610] process:532 unhandled grfe

I am using it with music-assistant The developer of music-assistant mentioned this is a harmless warning, and it seems to be true as squeezelite works just fine, but what is the warning and why does it appear so many times? Is there anything I could do to remove it or should I just turn logging off?

PaulWebster commented 5 months ago

grfe is a command in SlimProto that the server (usually LMS but in this case Music-Assistant) uses to give the player some graphics to display. But Squeezelite does not have a display ... so I guess it is not implemented and therefore it logs a unhandled request. Not checked ... but perhaps one of the CAPAbilities offered by the players is whether or not they have a screen and the server should not send the graphics if the player has said it does not support it.

barrelltitor commented 5 months ago

Thanks, makes sense. Looks like they are implementing a feature for display support, so that is probably where it comes from.

Can it actually cause any issues, or if I just disable logging for my container I should be good?

PaulWebster commented 5 months ago

Just had a very quick search of LMS code and looks like grfe is sent based on player type not on player specifically saying it supports it. So maybe music-assistant test should be on reported type.

cociweb commented 3 months ago

Resolved.