search

ralph-irving / squeezeos-squeezeplay

Squeezeplay in Logitech Controller, Radio and Touch Squeezebox players community firmware
11 stars 6 forks source link

Separate brightness settings for playing/stopped #4

Open danielvijge opened 3 years ago

danielvijge commented 3 years ago

The Squeezebox Touch/Radio has two brightness settings: manual and automatic. The manual setting always has the same brightness level whether the device is being used, playing, stopped, or off. The automatic settings sets the brightness based on the environment light conditions. It doesn’t really work if you try to control the player in a dark room, and the minimal brightness level is set to a low level, because that the screen would be at the lowest level, and you can’t see a thing. This patch to change this behaviour. It changes the implementation of both automatic and manual setting.

For the automatic setting, it introduces four new brightness settings:

When the system is active (you touch the screen, or use the remote control) the brightness will remain between the active minimum and maximum. If a screen saver is on, the brightness will remain between the screen saver minimum and maximum. There is an option to always use the active setting when the Squeezebox is playing.

For the manual setting, you can set a manual brightness and a minimal brightness. Manual brightness is the brightness when the system is active, minimum brightness is the brightness when the screen saver is on. There are options to control when the screen should reduce its brightness to the minimum setting: when playing, when stopped, and/or when off.

The Now Playing screen saver is not really a screen saver, so the brightness cannot be reduced when you use this screen saver. A separate pull request (#3) is submitted for that. Although that patch is not a hard requirement for this patch to work.

The patch for the Touch is part of my repo.xml that is included in the official 3rd party extensions list. For the Touch it can be installed when Patch Installer is added. I don't have a radio, so I cannot test it. The patch is available in http://server.vijge.net/static/squeezebox/repo-beta.xml In the forum thread on the subject some users reported it to work, whilst others seem to have problems with it.

Translations only include English and Dutch. For all other languages English is used.

mw9 commented 3 years ago

Your repo shows maxTarget="*". Would it be a good idea, in due course, to make that 7, or whatever, to prevent the patch being offered to the Community version 8 software ?

danielvijge commented 3 years ago

Yes, should this be merged I will change the maxTarget to 7.*. I'll do the same for #3.

Just not sure if for patches the version refers to the version of the server or the player. It could exclude users who have 8.x on the server but haven't discovered the community firmware yet. However, I think the target audience who would install patches, is the same as those that can install the community firmware.