search

ralph-irving / squeezeos

Source code for the Logitech Controller, Radio and Touch Community Firmware
https://sourceforge.net/projects/lmsclients/files/squeezeos/
22 stars 7 forks source link

Increase robustness of config changes in applet #19

Closed dzenc closed 1 year ago

dzenc commented 1 year ago

Increase robustness of config changes by matching wildcards, and, in the worst case, if a match can't be found, appending the new config to the end of the file

ralph-irving commented 1 year ago

Thanks. I'll respin a release before posting in the forum.

dzenc commented 1 year ago

Sounds good. Just a heads up that I just started testing one more change, but it will take a few days (maybe a week) to know if it makes a difference.

When I released test build v1, due to a bug (mismatched ioctl ids), it accidentally disabled ioctls for both of the wmi commands from the wlan script (power and filter) and that was when I saw the big improvement in stability. After fixing the ioctl bug, I disabled the power command for subsequent builds (e.g v9.x), but the filter command still remains in the script. (Mostly because I didn’t really understand what the filter command did or potential impact of removal.)

Anyway, I am now testing with filter out too to see if it makes any difference. I’m gonna give it at least 4-5 days to see if there is any long term impact, so I don’t think you should hold up the build.

dzenc commented 1 year ago

Anyway, I am now testing with filter out too to see if it makes any difference.

Two days in and it's not looking like this change has had any impact. I will keep testing it for a few more days, but I suspect what's already checked in is the best there is for now. :)