macOS multimedia key support

ralph-irving / squeezeplay

Squeezeplay software player for Lyrion Music Server.

https://sourceforge.net/projects/lmsclients/files/squeezeplay/

50 stars 14 forks source link

macOS multimedia key support #13

Closed kerneljake closed 6 months ago

kerneljake commented 1 year ago

macOS multimedia key support

uses VLC’s keytap technique with some safety modifications (compile-time array, +initialize(), [super dealloc])

macOS miscellaneous fixes:

cmd-H and cmd-Q hide and quit, respectively
fix compiler warnings in SDL_Main - SDLApplication category override, sdlMain delegate casting
fix compiler warning in SDL_QuartzEvents for TISCopyCurrentKeyboardLayoutInputSource()

tested on x86_64 10.13.6 and M1 13.5.2

ralph-irving commented 1 year ago

Thanks for the enhancement. Works well on my 12.6.9 M1 pro, however, I've been unable to get it working on an older 10.12.6 x86_64 system. Squeezeplay hangs as soon as I try to navigate the menus with this PR applied. Still trying to figure out what's happening.

kerneljake commented 1 year ago

I cannot reproduce the hang on my 10.12.6 x86_64 system.

% uname -a
Darwin Jakes-iMac.local 16.7.0 Darwin Kernel Version 16.7.0: Sun Jun  2 20:26:31 PDT 2019; root:xnu-3789.73.50~1/RELEASE_X86_64 x86_64

ralph-irving commented 1 year ago

Thanks for checking. I'd really like to figure out what's happening on my system before merging the change. Do you have a remote paired to your 10.12 mac? I do and use it daily with vlc.

kerneljake commented 1 year ago

I rummaged around and found an ancient White remote (A1156), but I lack hardware that is old enough to have an infrared receiver.

ralph-irving commented 11 months ago

In the end I had to refresh my local git source to get a working build and have merged this pull request. I kept the original broken sources in the hope of figuring out the cause. Squeezeplay now works with the aluminium remote (A1294). Unfortunately, when I press the play/pause button on the remote to pause squeezeplay, the itunes app launches and starts playing the last playlist. Doesn't happen when I use the remote with VLC on the same system. I'm sure it's something we can figure out now that it works.

kerneljake commented 11 months ago

I ordered a Flirc receiver today... I'll investigate once it arrives.

ralph-irving commented 10 months ago

I recently started having the Music app launch on my M1 macpro using SqueezePlay when I press the play/pause button on the touch bar. I wasn't doing it when I first tried it. Not sure what's changed, other than applying the several 12.x updates released recently. Unfortunately, I wiped my mac mini that had 10.12 and the remove and have installed linux on it, so I can't test on that system anymore. Have you had a chance to try it with the flirc yet?

kerneljake commented 10 months ago

I tried to reproduce the symptom with Flirc, and I cannot reproduce it. Everything works fine. 🤷 Maybe Flirc is not a perfect replica of the way actual Apple IR hardware behaves.

urknall commented 10 months ago

I recently started having the Music app launch on my M1 macpro using SqueezePlay when I press the play/pause button on the touch bar. I wasn't doing it when I first tried it. Not sure what's changed, other than applying the several 12.x updates released recently. Unfortunately, I wiped my mac mini that had 10.12 and the remove and have installed linux on it, so I can't test on that system anymore. Have you had a chance to try it with the flirc yet?

I am still running SqueezePlay-M1-8.0.1r1402.dmg on my M1 iMac at work, can i get an actual git dmg somewhere to do also some tests?

EDIT: I managed to compile squeezeplay by myself, everything is working fine here also (MacOS 12.7.1):

Darwin iMac-von-urknall.local 21.6.0 Darwin Kernel Version 21.6.0: Wed Oct 4 23:54:48 PDT 2023; root:xnu-8020.240.18.704.15~1/RELEASE_ARM64_T8101 arm64