Add duration serializer, deserializer

ralphbean / taskw

python taskwarrior api

http://threebean.org

GNU General Public License v3.0

175 stars 47 forks source link

Add duration serializer, deserializer #160

Closed bergercookie closed 8 months ago

bergercookie commented 2 years ago

Hi @ralphbean ,

This PR adds serdes functions for the Duration class. I decided to implement them in taskwarrior_syncall so I thought of pushing them to this project ^^

The format for the duration field is described albeit briefly, here

Additional changes:

fixes some failing doctests in warrior.py and also enabling checking the doctests as part of setup.cfg.
disables running pytest on the taskwarrior/ directory which is downloaded automatically during CI.
Enables make -j to speed up the CI process

bergercookie commented 2 years ago

I hadn't realised that a duration field may be presented in formats other than the ISO8601, e.g., 1mo, daily, etc.

I would suggest that we keep this PR contained and handle these extra fields in a separate PR and line of work. For now I'm keeping the recur field as a StringField instead to avoid having to deal with this.

Unittests pass so it's ready to merge from my side. Thoughts?

bergercookie commented 2 years ago

@ralphbean, @coddingtonbear do you have some time to skim through this PR?

bergercookie commented 1 year ago

Can I please get some eyes on this one ? I would really like to get this merged as I'm using these features in https://github.com/bergercookie/taskwarrior-syncall/