ralphcrutzen / RGBDigit

Arduino library for http://rgbdigit.com/
GNU General Public License v2.0
4 stars 5 forks source link

Paramaterisation of segments per digits and NeoPixel type #5

Closed yknivag closed 6 years ago

yknivag commented 6 years ago

Dear ralphcrutzen,

Thank you most kindly for the work you have done to produce this excellent library. I have, for my own purposes, created my own NeoPixel 7-segment display and have found this library invaluable in driving it.

My own display was created with the decimal point and also with a different type of NeoPixel from that used in the commercial RGBDigit product and so I had to make some amendments to the library to make it work. Rather than hard coding the changes I changed them to be parameters so that I may use the library for it's correct purpose also.

In the spirit of open source I offer, by way of this PR, the changes I have made to everyone involved. All changes are 100% backward compatible but will allow people who use their own display to take advantage of your excellent work.

I have not added an example to show how to use the changes, but I have made relevant changes to the readme.

Once again thank you for the hard work and dedication that has gone into creating this library.

Kind Regards,

Gavin.