search

ralphcrutzen / RGBDigit

Arduino library for http://rgbdigit.com/
GNU General Public License v2.0
4 stars 5 forks source link

Correction for PR#5 #6

Closed yknivag closed 6 years ago

yknivag commented 6 years ago

Dear @ralphcrutzen

Many thanks for merging my previous PR (#5) I am very grateful.

Unfortunately there is something of a flaw with it. I had made the changes and tested it using Eclipse (rather than the Arduino IDE) and the changes I made worked there. However they don't work for a sketch compiled in the Arduino IDE as the compiler doesn't pass the-D parameter and so #defines made in the main sketch are not respected in the library code.

The only way round this was to make the segmentsPerDigit a parameter in the constructor as opposed to simply setting a #define in the sketch.

Apologies for the inconvenience of raising a second request - I should have tested the code in the Arduino IDE myself first. I have raised the correction as quickly as I could - I hope you haven't had any complaints that the new functionality didn't work.

Kind Regards,

Gavin.

ralphcrutzen commented 6 years ago

No need to apologise! I'm glad - and always a bit surprised :-) when someone uses and improves my code.