search

ralphieraccoon / MilSymb

LaTeX package for TikZ based drawing of military symbols as per NATO APP-6(C)
Other
8 stars 3 forks source link

add armoured infantry #21

Open ycphs opened 1 year ago

ycphs commented 1 year ago

add armoured infantry

ralphieraccoon commented 1 year ago

Hi, thanks for the PR! Can you please confirm if this is from APP-6(C) or APP-6(D)? I can't find it in APP-6(C) but I might have just missed it. I've been meaning in incorporate the new revision into the package for some time, but I'm thinking about if it would be best to split the changes off into a different file and let users pick the revision with a package option.

ycphs commented 1 year ago

It is displayed APP-6D

Thats the description:

ARMOURED/MECHANIZED/ TRACKED Type: Entity Subtype Entity/Entity Type: MOVEMENT AND MANOEUVRE/INFANTRY Symbol Set Code: 10 Code: 121102 Icon Type: Main

ralphieraccoon commented 1 year ago

Thanks! As it's in revision D I'll hold off on any merge for now until I work out how I'm going to integrate both versions into the package. If you're willing to help create more symbols from revision D in the meantime, feel free to add them to the PR (and change the title accordingly) it would be a great help, then I can work on sorting out the structure of the package on the back end.

ycphs commented 1 year ago

It is already stated in APP-6C

Icons in the main sector (figure 3-6) normally reflect the main function of the symbol, but in some cases can also reflect modifying information (e.g., armoured engineers). Table 3-3 below shows the icons for use in land unit symbols in the main sector of the A field of the symbol. In most cases, the dimensions of the icon will be sized to occupy as much area in the main sector as is available. However, in some cases the icon may be reduced to allow more room for modifiers for better recognition or to allow for one icon to modify another (e.g., armoured/self-propelled artillery).

So armoured infantry should be allowed as well as armoured engineers.

ralphieraccoon commented 1 year ago

I think this is best implemented with a custom icon/modifier for APP-6C since there would be a lot of unique combinations (see the manual for instructions). But as it seems to be specifically defined in APP-6D so I will add it in there. I'm generally going for if the icon is not in a table in the documentation, it's not added as a value in the package.