GH-28: Refactor dependencies to allow programmatic access.

ralphje / imagemounter

Command line utility and Python package to ease the (un)mounting of forensic disk images

MIT License

118 stars 36 forks source link

GH-28: Refactor dependencies to allow programmatic access. #29

Closed gtback closed 6 years ago

gtback commented 6 years ago

Create classes for CommandDependency, PyModuleDependency.
Add special class for handling "magic" dependency.
Add DependencySection class for grouping dependencies.
Simplify CheckAction to use these new classes

Output of imount --check should be identical to before.

gtback commented 6 years ago

I tested this as best I could by comparing the output of imount --check with and without this change, using the diff tool, and it should be byte-for-byte equivalent. Some of the magic scenarios were hard for me to test, so if there are any discrepancies, let me know and I'll fix them.

gtback commented 6 years ago

Thanks for the feedback. I'll try to incorporate all of that in the next few days (and fix the style error I had).

gtback commented 6 years ago

I updated the code to address the design issues you identified, @ralphje . Working on docs and tests now.

gtback commented 6 years ago

Ok, from my perspective I think this is good to go. If there are other changes you'd like me to make, I'm happy to.

gtback commented 6 years ago

Thanks, @ralphje.