search

ralphlange / procServ

Wrapper to start arbitrary interactive commands in the background, with telnet or Unix domain socket access to stdin/stdout
GNU General Public License v3.0
23 stars 23 forks source link

Modify restartMode oneshot feature to not halt while toggling #39

Closed bhill-slac closed 3 years ago

bhill-slac commented 4 years ago

Got many complaints from developers when we rolled out new procServ oneshot mode. If IOC process is not running and the developer tries to change restartMode, it kills procServ when the developer toggles through oneshot mode.

This commit sets firstRun true as restartMode is toggled. Thus, developers can toggle through oneshot mode w/o killing procServ and the IOC will run at least once before oneshot mode will kill procServ.

ralphlange commented 4 years ago

The request sounds very reasonable and the change looks appropriate.

ralphlange commented 3 years ago

I had to play a while to be able to reproduce the issue: you need to run the right order of actions to see it.

The fix is fine. Merging it.

ralphlange commented 3 years ago

Thanks a lot. Do you need a new official release at any point?