search

ralphlange / procServ

Wrapper to start arbitrary interactive commands in the background, with telnet or Unix domain socket access to stdin/stdout
GNU General Public License v3.0
23 stars 23 forks source link

Refactor generation of procServ messages #40

Open mark0n opened 3 years ago

mark0n commented 3 years ago

Replace fixed size char string buffers by std::string to rule out buffer overflows/truncating strings. By doing so we get rid of some compiler warnings.

Note: These changes leverage C++14 features but at the cost of some readability this could also be done with C++11 or even C++98. Which standard version are we shooting for?

ralphlange commented 3 years ago

C++11 is probably fine. Should we add a check for autoconf (like this one)?

mark0n commented 3 years ago

Not a bad idea. Please check if I added it in the right spot - autoconf predates my days as a software developer ;-)

mark0n commented 3 years ago

@ralphlange any idea how to deal with the failing AppVeyor build? On Debian ax_cxx_compile_stdcxx_11.m4 comes as part of the autoconf-archive package.