search

ralphlange / procServ

Wrapper to start arbitrary interactive commands in the background, with telnet or Unix domain socket access to stdin/stdout
GNU General Public License v3.0
23 stars 23 forks source link

Should procServ exit >0 when the process is terminated by a signal? #58

Open minijackson opened 1 year ago

minijackson commented 1 year ago

Hello!

We're currently using procServ with the --oneshot option, and ensuring that the systemd service has Restart=always. I think it's pretty nice since unexpected restarts are logged into journald.

One thing that I found out, is that if the process managed by procServ is killed (by SIGKILL, or SIGSEGV, for example), procServ returns 0.

This bit me at first because I had configured Restart=on-failure, and systemd saw that the process exited successfully.

I think returning 0 is surprising in this instance, and it might be nice to return >0. We might even want to exit with the standard "Fatal error signal" exit code: https://tldp.org/LDP/abs/html/exitcodes.html

Thanks a lot!

ralphlange commented 1 year ago

Sounds very reasonable.