ralphwetzel / theonionbox

Dashboard to monitor Tor node operations
MIT License
122 stars 17 forks source link

sqlite dependency isn't listed? #55

Closed yurivict closed 5 years ago

yurivict commented 5 years ago

The port user submitted this patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=196168&action=diff

I copied the dependencies from setup.py. It looks like sqlite might be missing there.

Thanks!

ralphwetzel commented 5 years ago

sqlite3 is part of the Python Standard Library, since v2.5. It thus should be part of each standard distro - and no dedicated dependency notion necessary.

rainlance commented 5 years ago

Running without py-sqlite3 produces the following error on FreeBSD

Traceback (most recent call last): File "/usr/local/bin/theonionbox", line 11, in load_entry_point('theonionbox==4.2.1', 'console_scripts', 'theonionbox')() File "/usr/local/lib/python2.7/site-packages/theonionbox/main.py", line 18, in main from .theonionbox import main as onion_main File "/usr/local/lib/python2.7/site-packages/theonionbox/theonionbox.py", line 1031, in from tob.persistor import Storage File "/usr/local/lib/python2.7/site-packages/theonionbox/tob/persistor.py", line 2, in import sqlite3 File "/usr/local/lib/python2.7/sqlite3/init.py", line 24, in from dbapi2 import File "/usr/local/lib/python2.7/sqlite3/dbapi2.py", line 28, in from _sqlite3 import ImportError: No module named _sqlite3

yurivict commented 5 years ago

I created a bug record for FreeBSD: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230613

Closing it here.

ralphwetzel commented 5 years ago

As consequence to this comment of your bug report I should provide some measures to ensure that the packages demanded specifically for FreeBSD are properly defined. Can you give me some guidance what is necessary? Is it just py-sqlite3 ... or something else?

yurivict commented 5 years ago

Hi Ralph,

I've already corrected this in the port: https://svnweb.freebsd.org/ports/head/security/theonionbox/Makefile?revision=477126&view=markup#l28

But I don't think that you need to do anything, because people normally install software from ports, and the port is fixed.

Yuri

ralphwetzel commented 5 years ago

:ok_hand: