search

ralsina / aranduka

Automatically exported from code.google.com/p/aranduka
0 stars 1 forks source link

The guess.ui dialog should have editable fields #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently it displays checkboxes so you can either use the current title as a 
guess hint or not.

However, if you want to try different variations on titles or authors, you need 
to cancel, change in the editor, save, and guess again.

That's not a great workflow.

Original issue reported on code.google.com by roberto.alsina on 1 Feb 2011 at 7:26

GoogleCodeExporter commented 9 years ago

Original comment by roberto.alsina on 1 Feb 2011 at 7:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision b3fbe4884e.

This should fix the issue, will request review.

Original comment by roberto.alsina on 1 Feb 2011 at 7:47

GoogleCodeExporter commented 9 years ago 
It's much better know.

Take a look at the exception, though:

Traceback (most recent call last):
  File "/home/elbarto/issue33/src/book_editor.py", line 101, in on_guessButton_clicked
    authors = u', '.join(authors)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1: ordinal 
not in range(128)

Original comment by andresgattinoni on 1 Feb 2011 at 8:09

GoogleCodeExporter commented 9 years ago 
I wonder where the ascii is coming from.

Original comment by roberto.alsina on 1 Feb 2011 at 8:27

GoogleCodeExporter commented 9 years ago 
No idea. These are the suggestions that are listed when the error comes up:

 * Bulletin boards and 3-D showcases that capture them with pizzazz by Karen Hawthorne, Jane E. Gibson

 * Health and health care as social problems by Peter Conrad, Valerie Leiter

 * Chasing Death Losing a Child to Suicide. by Jan Andersen

BTW, I have no idea how Google guessed those books from the title "Autumn 
Leaves".
I tried with another book ("Alice in Wonderland", which returns a much longer 
list of suggestions) and the error didn't show.

Original comment by andresgattinoni on 1 Feb 2011 at 8:40

GoogleCodeExporter commented 9 years ago 
Maybe we are getting str from google instead of unicode?

Original comment by roberto.alsina on 1 Feb 2011 at 8:54

GoogleCodeExporter commented 9 years ago 
Maybe. I don't know what the gdata-client does. Anyhow neither of the current 
guesser plugins do any (re)encoding of the incoming data. Should they?

Original comment by andresgattinoni on 1 Feb 2011 at 9:31

GoogleCodeExporter commented 9 years ago 
Well, to avoid that, they should really provide unicode.

Original comment by roberto.alsina on 2 Feb 2011 at 1:02

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 18a4dc62e5.

Merged the writable fields on the guess dialog.

Original comment by roberto.alsina on 2 Feb 2011 at 2:27