Tags/Shelves inconsistency

ralsina / aranduka

Automatically exported from code.google.com/p/aranduka

0 stars 1 forks source link

Tags/Shelves inconsistency #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

There's an inconsistency with the usage of the name "tags" or "shelves" for 
book tags.

On the database models we're calling them tags. The same in the menu at the 
left of the list. However, when you edit a book you define shelves.

We should pick one and stick to it.

Original issue reported on code.google.com by andresgattinoni on 25 Jan 2011 at 3:05

GoogleCodeExporter commented 9 years ago

BTW, the singular of "shelves" is "shelf", *not* "shelve". "Shelve" is a 
transitive verb which means "put something in a shelf". This word is used many 
times accross the code and should be changed.

Original comment by andresgattinoni on 25 Jan 2011 at 10:06

GoogleCodeExporter commented 9 years ago

ugh, yes. I'll fix it.

Original comment by roberto.alsina on 26 Jan 2011 at 6:38

Changed state: Started

GoogleCodeExporter commented 9 years ago

Fix on issue4 branch. Review please?

Original comment by roberto.alsina on 26 Jan 2011 at 6:48

GoogleCodeExporter commented 9 years ago

Seems ok. Still the inconsistency between tags and shelves persists. 
I think it's ok to keep "shelf" for the ShelfView plugins. However, when you 
edit a book you have a "Shelves" menu which actually defines tags (which are 
the same that are listed on the "Books by Tag" selfview).

Original comment by andresgattinoni on 26 Jan 2011 at 6:55

GoogleCodeExporter commented 9 years ago

I think I like shelves better than tags, what do you think?

Original comment by roberto.alsina on 26 Jan 2011 at 7:10

GoogleCodeExporter commented 9 years ago

Despite what Goodreads may say, I never understood how I could have the same 
book in two different shelves at the same time :-P

I think tags is clearer for non-goodreads users and, internally, it helps us to 
establish a difference between a Tag and a ShelfView.

But I doesn't really bother me which name we pick as long as we pick one. We 
could ask for opinions in the mailing list.

Original comment by andresgattinoni on 26 Jan 2011 at 7:15

GoogleCodeExporter commented 9 years ago

Good idea. You or me? :-)

Original comment by roberto.alsina on 26 Jan 2011 at 7:30

GoogleCodeExporter commented 9 years ago

Did you merge the issue4 branch?

Original comment by andresgattinoni on 26 Jan 2011 at 11:46

GoogleCodeExporter commented 9 years ago

Nope!

Original comment by roberto.alsina on 27 Jan 2011 at 12:10

GoogleCodeExporter commented 9 years ago

Original comment by andresgattinoni on 28 Jan 2011 at 5:37

Added labels: Milestone-Release1.0

GoogleCodeExporter commented 9 years ago

This issue was updated by revision 0d88fcee43f3.

I have autocratically decided to fix this issue changing "shelves" for "tags", 
because of the reasons I exposed on Jan 26, 2011. I would kindly accept to be 
overthrown by a democratic decision to do otherwise. However, until then, this 
matter is settled.

Original comment by andresgattinoni on 19 Jan 2012 at 3:31

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 0d88fcee43f3.

Original comment by andresgattinoni on 19 Jan 2012 at 3:31

Changed state: Fixed