search

ralsina / aranduka

Automatically exported from code.google.com/p/aranduka
0 stars 1 forks source link

"Open ..." option on context menu expands too much #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When you right-click on a book you get the option to open it. When the file's 
name is too long, the context menu expands to fit the length. Since we're 
generating file names with a format: ID-Title-Author.ext, it's common that they 
are really long, and it looks kinda ugly (see pic).

I suggest we change it to "Open book" when there's only one file, and "Open 
book" -> "in ePub", "in FictionBook2" when there are more than one files to 
choose.

What do you think?

Original issue reported on code.google.com by andresgattinoni on 12 Feb 2011 at 2:33

Attachments:

GoogleCodeExporter commented 9 years ago 
Yes, fine by me. Keep in mind that there may be more than one copy in the same 
format so that has to be considered, but yeah, it sucks :-)

Original comment by roberto.alsina on 12 Feb 2011 at 2:57

GoogleCodeExporter commented 9 years ago 
Mmm good point. Maybe in that case we could show "15-Very long title...epub" 
and "Another very long title...epub" or something like that.

Original comment by andresgattinoni on 12 Feb 2011 at 3:02

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 9cc6b69d5a.

I changed the title of the option to "Open book" when there's only one file and 
also made some fixes to the menu which wasn't working properly.
We still need to decide the best way to display the list of available files 
when there is more than one file in the same format.

Original comment by andresgattinoni on 12 Feb 2011 at 8:37

GoogleCodeExporter commented 9 years ago 
I've changed the submenu for multiple files on revision 68251387b4. For each 
file format, if there's only one file it shows "In <format>".
If there's more than one file with the same format it shows the file name.
Review? Opinions?

Original comment by andresgattinoni on 12 Feb 2011 at 11:50

GoogleCodeExporter commented 9 years ago

Original comment by andresgattinoni on 15 Feb 2011 at 11:55

GoogleCodeExporter commented 9 years ago 
Andrés, With some books the Open Menu Option is disabled. It happens for 
example with Cujo (is a .fb2 in the "libros" folder). Is this the expected 
behavior?

Original comment by algoz...@gmail.com on 15 Feb 2011 at 1:27

GoogleCodeExporter commented 9 years ago 
That should happen only if the book file is not valid (either it doesn't exist 
or is empty). This is done by the Main._check_file method on main.py (see issue 
20).

Original comment by andresgattinoni on 15 Feb 2011 at 1:32

GoogleCodeExporter commented 9 years ago 
Cool! That particular file is empty, so is OK then! But couldn't / shouldn't we 
enable the menu option but show a message informing the user that the file is 
invalid instead?

Original comment by algoz...@gmail.com on 15 Feb 2011 at 1:47

GoogleCodeExporter commented 9 years ago 
Yes, we could handle this better. I suggest you report it in a new issue and we 
can discuss the best approach there.

Original comment by andresgattinoni on 15 Feb 2011 at 1:51

GoogleCodeExporter commented 9 years ago 
Other than the issue with invalid files, any other comments/reviews? Shall I 
merge?

Original comment by andresgattinoni on 19 Feb 2011 at 2:00

GoogleCodeExporter commented 9 years ago 
I say merge.

Original comment by roberto.alsina on 19 Feb 2011 at 10:54

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 2d640f39f1.

Original comment by andresgattinoni on 19 Feb 2011 at 12:35