Closed keesse closed 2 months ago
Thanksfor the report, I'll take a look!
They seem to be working for me right now, maybe I fixed it at some point :-D
Could you check with the latest code from main? If that works I will make another release.
I did a git pull origin main
to update the source directory, but make
gave an error, so I tried a new clone after removing the old directory, but
with the same result:
markterm on ๎ main is ๐ฆ v0.3.0 via ๐ฎ v1.13.1 โฏ make shards build -Dstrict_multi_assign -Dno_number_autocast Resolving dependencies Fetching https://github.com/ralsina/tartrazine.git Fetching https://github.com/ralsina/sixteen.git Fetching https://github.com/icyleaf/markd.git Fetching https://github.com/chenkovsky/docopt.cr.git Fetching https://github.com/schovi/baked_file_system.git Fetching https://github.com/crystal-china/base58.cr.git Installing markd (0.5.0) Installing baked_file_system (0.10.0) Installing base58 (0.1.0 at 2b0564a) Installing sixteen (0.3.0) Installing docopt (0.2.0 at 620fce4) Installing tartrazine (0.6.1) Writing shard.lock Building: markterm Error target markterm failed to compile: Showing last frame. Use --error-trace for full trace.
In src/terminal.cr:100:30
100 | formatter.format(source, lexer) ^---- Error: expected argument #2 to 'Tartrazine::Ansi#format' to be Tartrazine::Lexer, not Tartrazine::BaseLexer
Overloads are:
make: *** [Makefile:2: build] Error 1
Op ma 26 aug 2024 om 17:34 schreef Roberto Alsina @.***
:
They seem to be working for me right now, maybe I fixed it at some point :-D
Could you check with the latest code from main? If that works I will make another release.
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2310498273, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKTDLORFUPRKHQMMEZR2DTZTNDHXAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGQ4TQMRXGM . You are receiving this because you authored the thread.Message ID: @.***>
Ok, pushed a new release of tartrazine and a new commit in markterm, this combination should work :-)
Unfortunately not
markterm on ๎ main is ๐ฆ v0.3.0 via ๐ฎ v1.13.2 took 2m31s โฏ git pull origin main remote: Enumerating objects: 5, done. remote: Counting objects: 100% (5/5), done. remote: Compressing objects: 100% (1/1), done. remote: Total 3 (delta 2), reused 3 (delta 2), pack-reused 0 (from 0) Unpacking objects: 100% (3/3), 333 bytes | 333.00 KiB/s, done. From https://github.com/ralsina/markterm
markterm on ๎ main is ๐ฆ v0.3.0 via ๐ฎ v1.13.2 โฏ make shards build -Dstrict_multi_assign -Dno_number_autocast Resolving dependencies Fetching https://github.com/icyleaf/markd.git Fetching https://github.com/chenkovsky/docopt.cr.git Fetching https://github.com/ralsina/tartrazine.git Fetching https://github.com/ralsina/sixteen.git Fetching https://github.com/schovi/baked_file_system.git Fetching https://github.com/crystal-china/base58.cr.git Unable to satisfy the following requirements:
sixteen (branch main)
required by shard.yml
sixteen (0.3.0)
required by shard.lock
sixteen (*)
required by tartrazine 0.6.1
Failed to resolve dependencies
make: *** [Makefile:2: build] Error 1remove your lib/ and shard.lock first
And sorry about all the complications, but hey, you are AFAIK the second person to try this :-D
Removing the shard.lock did it, I could build. However from the terminal I am using Hyper gave the same problem, I then tried Warp, that worked! Tried the standard Linux Mint Terminal, that gave errors, also Terminator, appearingly they do not support links
markterm on ๎ main is ๐ฆ v0.3.0 via ๐ฎ v1.13.2 โฏ bin/markterm README.md Unhandled exception: Missing ENV key: "TERM_PROGRAM" (KeyError) from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/env.cr:57:7 in 'fetch' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/env.cr:22:5 in '[]' from src/terminal.cr:8:8 in 'supports_links?' from src/markterm.cr:183:14 in 'text' from lib/markd/src/markd/renderer.cr:92:13 in 'render' from src/markterm.cr:203:7 in 'render' from src/markterm.cr:212:5 in 'to_term:theme:code_theme' from src/main.cr:21:8 in 'main' from src/main.cr:32:1 in '__crystal_main' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/crystal/main.cr:118:5 in 'main_user_code' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/crystal/main.cr:104:7 in 'main' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/crystal/main.cr:130:3 in 'main' from /lib/x86_64-linux-gnu/libc.so.6 in '??' from /lib/x86_64-linux-gnu/libc.so.6 in '__libc_start_main' from bin/markterm in '_start' from ???
Ok, the support for html-style links in different terminals is ... spotty?
I tried it in kitty and alacritty, will check on a few of the ones you mentioned.
I tried hyper. Markterm is not even trying to do links in it!
What hyper does is recognize URL patterns but it reads <https://foo.com>
as a link to https://foo.com>
which is different from any other terminal.
For terminator (and probably other VTE based terminals) itยดs a bug in markterm I can fix tonight
You have been really helpful dude!
Fixed in master for terminator (and probbaly for mint too)
For hyper I created an issue because it looks like a bug: https://github.com/vercel/hyper/issues/8031
If you find any other weird behaviour just open another issue.
A shard version issue with tartrazine (I did remove shard.lock)
markterm on ๎ main is ๐ฆ v0.3.0 via ๐ฎ v1.13.2
โฏ git pull origin main
remote: Enumerating objects: 27, done.
remote: Counting objects: 100% (27/27), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 21 (delta 12), reused 20 (delta 11), pack-reused 0 (from 0)
Unpacking objects: 100% (21/21), 3.56 KiB | 145.00 KiB/s, done.
From https://github.com/ralsina/markterm
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 โฏ make shards build -Dstrict_multi_assign -Dno_number_autocast Resolving dependencies Fetching https://github.com/chenkovsky/docopt.cr.git Fetching https://github.com/ralsina/tartrazine.git Fetching https://github.com/ralsina/sixteen.git Fetching https://github.com/icyleaf/markd.git Fetching https://github.com/ralsina/baked_file_system.git Fetching https://github.com/crystal-china/base58.cr.git Shard "tartrazine" version (0.6.1) doesn't match tag version (0.6.3) Using markd (0.5.0) Using baked_file_system (0.10.0 at beb3731) Using base58 (0.1.0 at 2b0564a) Installing sixteen (0.3.0 at b133e02) Using docopt (0.2.0 at 620fce4) Using tartrazine (0.6.3) Writing shard.lock Building: markterm
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 took 12s โฏ ll bin totaal 8128 drwxrwxr-x 2 kees kees 0 aug 27 16:39 . drwxrwxr-x 7 kees kees 0 aug 27 16:38 .. -rwxrwxr-x 1 kees kees 6420160 aug 27 16:39 markterm
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 โฏ bin/markterm README.md Unhandled exception: Unknown lexer: docopt (Exception) from lib/tartrazine/src/lexer.cr:30:5 in 'lexer_by_name' from lib/tartrazine/src/lexer.cr:13:12 in 'lexer' from src/terminal.cr:99:13 in 'highlight' from src/markterm.cr:63:16 in 'code_block' from lib/markd/src/markd/renderer.cr:70:13 in 'render' from src/markterm.cr:203:7 in 'render' from src/markterm.cr:212:5 in 'to_term:theme:code_theme' from src/main.cr:21:8 in 'main' from src/main.cr:32:1 in '__crystal_main' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/crystal/main.cr:118:5 in 'main_user_code' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/crystal/main.cr:104:7 in 'main' from /home/kees/.asdf/installs/crystal/1.13.2/share/crystal/src/crystal/main.cr:130:3 in 'main' from /lib/x86_64-linux-gnu/libc.so.6 in '??' from /lib/x86_64-linux-gnu/libc.so.6 in '__libc_start_main' from bin/markterm in '_start' from ???
The warning is harmless.
I'll do a fix for the error tonight.
Version 0.3.2 with the fix is now out.
I did a pull and the Makefile disappeared! Copied it from an old directory and could build. The build indeed worked in the Mint Terminal and Terminator with Ctrl+Left mouse button, like you wrote not in Hyper
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 โฏ git pull origin main remote: Enumerating objects: 36, done. remote: Counting objects: 100% (36/36), done. remote: Compressing objects: 100% (12/12), done. remote: Total 28 (delta 17), reused 27 (delta 16), pack-reused 0 (from 0) Unpacking objects: 100% (28/28), 3.56 KiB | 113.00 KiB/s, done. From https://github.com/ralsina/markterm
I am migrating from Makefiles to a different tool. You can always build using "shards build" anyway. I just updated the build instructions to say that.
On Tue, Aug 27, 2024 at 6:37โฏPM Kees @.***> wrote:
I did a pull and the Makefile disappeared! Copied it from an old directory and could build. The build indeed worked in the Mint Terminal and Terminator with Ctrl+Left mouse button, like you wrote not in Hyper
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 โฏ git pull origin main remote: Enumerating objects: 36, done. remote: Counting objects: 100% (36/36), done. remote: Compressing objects: 100% (12/12), done. remote: Total 28 (delta 17), reused 27 (delta 16), pack-reused 0 (from 0) Unpacking objects: 100% (28/28), 3.56 KiB | 113.00 KiB/s, done. From https://github.com/ralsina/markterm
- branch main -> FETCH_HEAD c4617e3 https://github.com/ralsina/markterm/commit/c4617e39859d3f349674a7d80a71f51f5d3e661e ..8b88a5c https://github.com/ralsina/markterm/commit/8b88a5c765487f88927b6068799cbe3183047512 main -> origin/main Updating c4617e3 https://github.com/ralsina/markterm/commit/c4617e39859d3f349674a7d80a71f51f5d3e661e ..8b88a5c https://github.com/ralsina/markterm/commit/8b88a5c765487f88927b6068799cbe3183047512 Fast-forward .gitignore | 1 + CHANGELOG.md | 22 ++++++++++++++++++++++ Hacefile.yml | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Makefile | 23 ----------------------- README.md | 1 + build_static.sh | 4 ++-- do_release.sh | 15 +++++++++++++++ shard.yml | 6 +++++- src/terminal.cr | 6 +++++- 9 files changed, 142 insertions(+), 27 deletions(-) create mode 100644 Hacefile.yml delete mode 100644 Makefile create mode 100755 do_release.sh
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2313623857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAMKZ2KRBCJ6QUH5CURF3ZTTWR3AVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGYZDGOBVG4 . You are receiving this because you modified the open/close state.Message ID: @.***>
Hi Robert,
I did a new git clone
and a shards build
, that worked fine, only I
still got:
Shard "tartrazine" version (0.6.1) doesn't match tag version (0.6.3)
Should you change the version number in lib/tartrzine/shards.yml from 0.6.1 to 0.6.3?
P.s. I have a feature request: paging When I page the output throught less, I lose the colors, so if you can build in some form of paging, that would be great!
Regards,
Kees
Op di 27 aug 2024 om 23:40 schreef Roberto Alsina @.***
:
I am migrating from Makefiles to a different tool. You can always build using "shards build" anyway. I just updated the build instructions to say that.
On Tue, Aug 27, 2024 at 6:37โฏPM Kees @.***> wrote:
I did a pull and the Makefile disappeared! Copied it from an old directory and could build. The build indeed worked in the Mint Terminal and Terminator with Ctrl+Left mouse button, like you wrote not in Hyper
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 โฏ git pull origin main remote: Enumerating objects: 36, done. remote: Counting objects: 100% (36/36), done. remote: Compressing objects: 100% (12/12), done. remote: Total 28 (delta 17), reused 27 (delta 16), pack-reused 0 (from 0) Unpacking objects: 100% (28/28), 3.56 KiB | 113.00 KiB/s, done. From https://github.com/ralsina/markterm
- branch main -> FETCH_HEAD c4617e3 < https://github.com/ralsina/markterm/commit/c4617e39859d3f349674a7d80a71f51f5d3e661e>
..8b88a5c < https://github.com/ralsina/markterm/commit/8b88a5c765487f88927b6068799cbe3183047512>
main -> origin/main Updating c4617e3 < https://github.com/ralsina/markterm/commit/c4617e39859d3f349674a7d80a71f51f5d3e661e>
..8b88a5c < https://github.com/ralsina/markterm/commit/8b88a5c765487f88927b6068799cbe3183047512>
Fast-forward .gitignore | 1 + CHANGELOG.md | 22 ++++++++++++++++++++++ Hacefile.yml | 91
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Makefile | 23 ----------------------- README.md | 1 + build_static.sh | 4 ++-- do_release.sh | 15 +++++++++++++++ shard.yml | 6 +++++- src/terminal.cr | 6 +++++- 9 files changed, 142 insertions(+), 27 deletions(-) create mode 100644 Hacefile.yml delete mode 100644 Makefile create mode 100755 do_release.sh
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2313623857, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAAMKZ2KRBCJ6QUH5CURF3ZTTWR3AVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGYZDGOBVG4>
. You are receiving this because you modified the open/close state.Message ID: @.***>
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2313627566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKTDLIFBZJFSEN2GAIWVVTZTTW3PAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGYZDONJWGY . You are receiving this because you authored the thread.Message ID: @.***>
On Wed, Aug 28, 2024 at 4:21โฏPM Kees @.***> wrote:
Hi Robert,
I did a new
git clone
and ashards build
, that worked fine, only I still got: Shard "tartrazine" version (0.6.1) doesn't match tag version (0.6.3)Should you change the version number in lib/tartrzine/shards.yml from 0.6.1 to 0.6.3?
It's already changed, no worries, it will settle on a future release.
P.s. I have a feature request: paging When I page the output throught less, I lose the colors, so if you can build in some form of paging, that would be great!
Using less -R
should work but doesn't because of something I can fix.
Next version will work.
Regards,
Kees
Op di 27 aug 2024 om 23:40 schreef Roberto Alsina @.***
:
I am migrating from Makefiles to a different tool. You can always build using "shards build" anyway. I just updated the build instructions to say that.
On Tue, Aug 27, 2024 at 6:37โฏPM Kees @.***> wrote:
I did a pull and the Makefile disappeared! Copied it from an old directory and could build. The build indeed worked in the Mint Terminal and Terminator with Ctrl+Left mouse button, like you wrote not in Hyper
markterm on ๎ main is ๐ฆ v0.3.1 via ๐ฎ v1.13.2 โฏ git pull origin main remote: Enumerating objects: 36, done. remote: Counting objects: 100% (36/36), done. remote: Compressing objects: 100% (12/12), done. remote: Total 28 (delta 17), reused 27 (delta 16), pack-reused 0 (from 0) Unpacking objects: 100% (28/28), 3.56 KiB | 113.00 KiB/s, done. From https://github.com/ralsina/markterm
- branch main -> FETCH_HEAD c4617e3 <
https://github.com/ralsina/markterm/commit/c4617e39859d3f349674a7d80a71f51f5d3e661e>
..8b88a5c <
https://github.com/ralsina/markterm/commit/8b88a5c765487f88927b6068799cbe3183047512>
main -> origin/main Updating c4617e3 <
https://github.com/ralsina/markterm/commit/c4617e39859d3f349674a7d80a71f51f5d3e661e>
..8b88a5c <
https://github.com/ralsina/markterm/commit/8b88a5c765487f88927b6068799cbe3183047512>
Fast-forward .gitignore | 1 + CHANGELOG.md | 22 ++++++++++++++++++++++ Hacefile.yml | 91
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Makefile | 23 ----------------------- README.md | 1 + build_static.sh | 4 ++-- do_release.sh | 15 +++++++++++++++ shard.yml | 6 +++++- src/terminal.cr | 6 +++++- 9 files changed, 142 insertions(+), 27 deletions(-) create mode 100644 Hacefile.yml delete mode 100644 Makefile create mode 100755 do_release.sh
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2313623857,
or unsubscribe <
. You are receiving this because you modified the open/close state.Message ID: @.***>
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2313627566, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEKTDLIFBZJFSEN2GAIWVVTZTTW3PAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGYZDONJWGY>
. You are receiving this because you authored the thread.Message ID: @.***>
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2316087415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAMK353SLXWJKW7F6ZPCDZTYPKJAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGA4DONBRGU . You are receiving this because you modified the open/close state.Message ID: @.***>
It was a one-liner and I have automated releases, so just did a quick one now, remember to use less -R
so it shows color.
less -R
does not show any colors, except the tick-boxes, at my system on
all different terminals
Op wo 28 aug 2024 om 22:35 schreef Roberto Alsina @.***
:
It was a one-liner and I have automated releases, so just did a quick one now, remember to use less -R so it shows color.
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2316204351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKTDLOLS7EBD2K33DOP77LZTYX7XAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGIYDIMZVGE . You are receiving this because you authored the thread.Message ID: @.***>
It does with the latest version :-)
[image: image.png]
On Fri, Aug 30, 2024 at 6:13โฏAM Kees @.***> wrote:
less -R
does not show any colors, except the tick-boxes, at my system on all different terminalsOp wo 28 aug 2024 om 22:35 schreef Roberto Alsina @.***
:
It was a one-liner and I have automated releases, so just did a quick one now, remember to use less -R so it shows color.
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2316204351, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEKTDLOLS7EBD2K33DOP77LZTYX7XAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGIYDIMZVGE>
. You are receiving this because you authored the thread.Message ID: @.***>
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2320600361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAMK3TQXO3SMO2EI76KZ3ZUAZTHAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGYYDAMZWGE . You are receiving this because you modified the open/close state.Message ID: @.***>
Yes, see my reply on the Forum. Thanks! Met vriendelijke groeten,
Kees Serier
30 aug. 2024 13:07:38 Roberto Alsina @.***>:
It does with the latest version :-)
[image: image.png]
On Fri, Aug 30, 2024 at 6:13โฏAM Kees @.***> wrote:
less -R
does not show any colors, except the tick-boxes, at my system on all different terminalsOp wo 28 aug 2024 om 22:35 schreef Roberto Alsina @.***
:
It was a one-liner and I have automated releases, so just did a quick one now, remember to use less -R so it shows color.
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2316204351, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEKTDLOLS7EBD2K33DOP77LZTYX7XAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGIYDIMZVGE>
. You are receiving this because you authored the thread.Message ID: @.***>
โ Reply to this email directly, view it on GitHub https://github.com/ralsina/markterm/issues/1#issuecomment-2320600361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAMK3TQXO3SMO2EI76KZ3ZUAZTHAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGYYDAMZWGE . You are receiving this because you modified the open/close state.Message ID: @.***>
โ Reply to this email directly, view it on GitHub[https://github.com/ralsina/markterm/issues/1#issuecomment-2320871094], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AEKTDLN2CAZGBCA5F5BASG3ZUBG7VAVCNFSM6AAAAABL5ZWKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQHA3TCMBZGQ]. You are receiving this because you authored the thread. [Tracking afbeelding][https://github.com/notifications/beacon/AEKTDLOLDB5DGEJXRWLZKV3ZUBG7VA5CNFSM6AAAAABL5ZWKHGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUKKWXLM.gif]
Hi ralsina,
I just build markterm and it works fine, so thanks! However when clicking on the shown URL's in the terminal, I get a 404, this is because there is a ">" added, when I remove this, I get the correct page. E.g. https://github.com/charmbracelet/glow%3E
Regards,
kees