ralucaa / PSD3

Undergraduate Teaching Session Management System
0 stars 0 forks source link

Semester 2 Sprint 1 Feedback #44

Open twsswt opened 10 years ago

twsswt commented 10 years ago

I have updated your jenkins build so that the whole team can see them (you had the wrong group name).

Check which resources you need to keep in version control - you still have an old directory of compiled class files in your project root. Also what is the difference between the ge2 and osgi sub directories in the root?

Good to see regular commits to the repository, although this seems to have ground to a halt since the end of the first sprint - hopefully not a bad sign?

A good initial component diagram. Your session manager is relatively complex, as it contains almost all the functionality. Could you indicate how the sub-components are wired together to realise the behaviour of the overall session component?

Generally a good source code structure that is clearly related to the design diagram. Remember that it is good practice to separate interface and implementation into separate bundles (the implementation is by convention placed in a sub-package called impl). It looks like you've started to do this (using the sub-package service in each component?).

You appear to make sporadic use of the ticket management system, although it is nice to see tickets created some time before they are closed, indicating you might be using the ticket management system for planning.

Generally - very good work!

Category available awarded New Tickets 2 2 Management 2 1 Commits 2 2 Component Diagram 3 2 Implementation in OSGi 2 2 User stories 3 3 Component interfaces 3 3 Build script 2 2 Jenkins 1 1 Total 20 18