search

ralucas / node-zillow

Node wrapper for Zillow API
https://ralucas.github.io/node-zillow
MIT License
70 stars 27 forks source link

fixing resultTag #4

Closed jefffriesen closed 9 years ago

jefffriesen commented 9 years ago

I tested all of the APIs listed in api-list.js. All of them worked great except for GetDeepSearchResults because of the incorrect resultTag. I stared at this for a while until I finally figured it out. The lowercase was obscure.

jefffriesen commented 9 years ago

Not sure why the Travis builds failed. I didn't touch the mocha tests. Do you know why or how to fix them?

ralucas commented 9 years ago

Hi Jeff, No worries on that. I have an environmental variable encoded in the travis.yml that doesn't work on PRs. I'll go ahead and merge these. Also, I'll make some stubs for the integration tests. Thanks for the PRs! And if you ever want to grab a cup of coffee in Boulder sometime, let me know: richard@richardalucas.com.

Cheers!

Richard