search

ram1123 / nanoAOD_skim

nanoAOD skiming code for vv senile-tonic VBS studies
0 stars 10 forks source link

GenAnalysis module added #34

Open YujiLee301 opened 10 months ago

YujiLee301 commented 9 months ago

GENZ_DaughtersId was omitted for now, as it looks difficult to get the access of a Daughter of Genpart directly from nanoAOD root file.

YujiLee301 commented 9 months ago

Hi, @ram1123 @vukasinmilosevic Names of branch has been set in the thread. Could u please take a look if there should be something else to be added?

YujiLee301 commented 9 months ago

Hi, @ram1123 @vukasinmilosevic. The sample list has been updated in this branch., including 2022 CDEFG era. Please take a look, thanks a lot!

ram1123 commented 9 months ago

Hi @YujiLee301 ,

I think you didn't added all the files that you changed. If I run over 2022 samples I get error. The reason for the error is that you are not adding info for 2022 in the post-proc.py

https://github.com/ram1123/nanoAOD_skim/blob/580b4d4c9665adf730c42844f8b9d8b90d836d67/post_proc.py#L65

Also, H4lCppModule() should be the first module added to the modules. Move this line before year if conditions

https://github.com/ram1123/nanoAOD_skim/blob/580b4d4c9665adf730c42844f8b9d8b90d836d67/post_proc.py#L84-L85

YujiLee301 commented 9 months ago

Hi @ram1123 ，2022 options added here，but all the input is the same with 2018 as we do not have inputs like MuonRoccoR or SF .csv files of 2022.

Meanwhile, year is an important input of H4LCppModule, especially in the construction function. So I don't think we should move Line 84.