Closed ondri124 closed 5 years ago
Thanks for your effort and this PR. Please give me some time to try what you did. I'll come back to you!
What is done in LocalDBHelper: remove last_changed add new version for database, add columns _ID, _DELETED
Merged ActivityDiarySuggestionProvider and ActivityDiaryContentProvider
HistoryActivity: add SEARCH_SUGGESTION_DISPLAY_COUNT database access through contetResolver If user search gardening , the gardening is deleted from table and then is inserted. So gardening is just only once in table, on the first row If table contains more than five rows, the oldest one is gardening
By merging the date-search stuff, your PR got conflicts. Can you try to merge the latest master HEAD, or do you want me to help here in some way?
And maybe you can add a copyright notice to all modified files and add your name (if you want) with an URL in strings.xml in the list of contributors.
I assume you have written the code yourself, do not infringe someone else's copyright and you are willing to publish these changes under the terms of the "GNU GPLv3 or later".
My plan would be to merge your code into master end of the week.
ok for you?
I implemented suggestions in diary activity:
I created new table suggestions with two columns: suggestion - contains the last searched queries last_changed - time stamp If table cointains more than five suggestions, then the oldest one suggestion is removed from table.
I changed sortedActivities method in class ActivityHelper. I think it is more practical if you start typing letter G and the gardering is on the first place. Also if you type more letters, then the suggestion are reduced.
Slightly refactor of interface DiaryColumns - removed redudant public static final modifieres