search

ramack / ActivityDiary

Android diary for any kind of activities
GNU General Public License v3.0
73 stars 37 forks source link

Add other changes #229

Closed ondri124 closed 5 years ago

ondri124 commented 5 years ago

I megred master with my repository. I tested it, everything works fine. I think everything is done from my side. If is there som problem please let me know :)

ramack commented 5 years ago

Thanks a lot for your efforts. After merging, I slightly updated the copyright notices to include your name, also I mentioned you in the contributors section in the About. Please check if it is fine for you like that and submit a PR if you want a change there. I also added the action to the database to redo the search only as it was initially done and not always doing a global search for the recent searches. The two remaining open points in #187 (configuration of the amount and keeping the fitting recent searches on typing I will probably leave for you or shift them to a later release, if it is fine for you..

ondri124 commented 5 years ago

Sure :) thank you Ramack for your reviews. I appreciate your patience and friendliness. It was nice experience with open source firts issue.

ramack commented 5 years ago

That's good. Thanks for the positive feedback. And I hope you'll stay tuned and continue to contribute to FLOSS projects, either this or others. Keep in mind: preserving freedom is effort, and so is to keep free projects alive. And great things can only be achieved in teams, not by one alone...