Bug: UNDO option loses effect after undoing the first selected activity

ramack / ActivityDiary

Android diary for any kind of activities

GNU General Public License v3.0

73 stars 37 forks source link

Bug: UNDO option loses effect after undoing the first selected activity #270

Open tingsu opened 5 years ago

tingsu commented 5 years ago

I have searched the history bug list, and have not found a similar bug.
The bug was found on the latest version 1.4.0 (can be reproduced on an Android emulator 6.0 and a Google Pixel 3 XL phone )
Bug: I install the version 1.4.0 and start the app, select any activity (e.g., cinema), and undo it (the undo cannot take effect). After this, if I select any other activities, and undo them, the UNDO option does not take any effect.
Reproducing video

ramack commented 5 years ago

Thanks for reporting this issue. I did not deeply try it now, but during my usage of the app I also had some cases where I wanted to undo the activity selection and it did not work, so I guess it is a bug and I'll take a look.

Edit: we might even want to add a NEW undo-feature, which is not limited to the time of the popup, but permanently possible...

tingsu commented 5 years ago

Thanks for quick reply! When I see this issue, I feel undoing an activity when the current activity (the top active activity) is "No Activity" is the culprit. If I undo an activity when the current activity is not "No Activity", it works fine. Hope this will help the bug fix.

tingsu commented 4 years ago

Any update? will this issue be fixed soon?

ramack commented 4 years ago

Your last comment sounds really plausible and I hope to be able to fix that one fast. These days am I still on other priorities, but also with the time since last release of ActivityDiary I have to reassess the priorities. Stay tuned!