ramack / ActivityDiary

Android diary for any kind of activities
GNU General Public License v3.0
73 stars 37 forks source link

Add feature to change the History #28

Open ramack opened 6 years ago

ramack commented 6 years ago

Allow inserting activities in the history view.

do so by adding a new activity to edit a diary entry

Echsecutor commented 6 years ago

change start and end times (with or without adjacent diary entries)

This would be a very helpful feature! Often I realized that I changed my activity like half an hour ago without pushing the button.

ramack commented 6 years ago

Do you have an idea how this would beat be implemented? E.g how should we get to the possibility to change the time? - this issue was meant to be in the diary/history view, but the usecase you mention should probably be easier to access that...

Suggestions welcome!

ramack commented 6 years ago

Thanks BTW for the feedback. This is very helpful!

ramack commented 6 years ago

I am not an expert in UI design. Is someone willing to suggest how the history edit can be implemented? - a simple picture could help already a lot.

For the current activity we could add a button, but another Floating action button will probably be an overload and just b tapping on the duration is not visible enough... on the other side decreasing the Selection view for the next activity is also not so good.

ramack commented 6 years ago

ok, my idea would be to in the history/diary:

on tap onto entries in the history, and also into the upper area of the main window, a new activity should open, showing

Any comments?

ramack commented 6 years ago

mh, editing the times graphically is hard to get right and intuitive. So I decided to go for a edit activity for now, to simplify note editing and allow to change start and end times.

Still we need further improvements, but I think they can wait a release.

ramack commented 6 years ago

@Echsecutor and others: what do you think about the current possibilities for editing the history? - I have some improvements in mind, but what is the top priority in your eyes?

Echsecutor commented 6 years ago

@ramack I have just tried 1.2.5 and I like the possibility to change durations. Thanks for adding it! My next most wanted feature would be remove activities. If I accidentally clicked something... ;)

ramack commented 6 years ago

😃 until deletion and insertion is implemented there is only one workaround: if you directly recognize that you touched the wrong activity you can use the UNDO in the snackbar after selecting the wrong one.

The real solution would be to provide a pull request, or wait.

But also highlighting it again and again is welcome, because it shows me what the users really want.

Echolon commented 6 years ago

I definitely suggest to inplement the remove possibility. Unless, the pretty much unusable.

michaelsam94 commented 5 years ago

I have question in delete history entry now the deleted activities shows when search so how I get rid of specific activity completely.

ramack commented 5 years ago

@michaelsam94 this is intended behavior, as the activities are the list of things you can select, and deleting one will not allow to select it in future, but in the diary I want it to stay as this is documenting 'history'. What you seems to be looking for is to delete all instances of a certain activity in the diary. This has to be possible, but it is not yet implemented.

michaelsam94 commented 5 years ago

willing to implement it?

ramack commented 5 years ago

Yes clearly. It is on top of the list, but I don't have much for free software these days.

The good thing is, that anyone is free to implement it - I promise to merge a pull request!