Closed tingsu closed 2 years ago
Any plan to fix this issue? I think adding an additional check on the input value would be able to totally fix this issue.
Thanks for reporting. And sorry for.the late answer. Clearly I have to fix this, and it should not be hard to do so. Currently being without computer and long time I did not invest into this app. Again, very sorry. In the last time I focused more on making up my mind on climate change and what.co.sequences it should have on my life than on programming apps.
But I'll try to push a new version soon. In case you are willing to contribute I'd happily review a PR!
Thanks for your reply. I understand your situation. I will try to issue a PR.
Hi @ramack , I inspected the code and located the culprit of this issue:
The issue can be quickly fixed by modifying this line to the code below:
int v;
try{
v = Integer.parseInt(value.replaceAll("\\D",""));
}catch (NumberFormatException e){
return;
}
But I am not very faimilar with the app logics. After I manually fixed in this way. It can indeed avoid the crash, but when I reopen the dialog. The invalid input will appear there (instead of showing the default value of 5
). I am not quite sure how to fix this. Hope my small fix could help you fix this issue in the next version.
This exception was found on the master (v1.4.0, the latest code version) and a Google Android phone.
STR: Go to setting, click
Location Service
, chooseNetwork
, openUpdate period
, delete the default value "5" (leave the EditText empty), and clickOK
.The exception trace:
Once this issue happens, the
setting
page cannot be opened, and the app crashes with the exception trace below.