ramakrishnach04 / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

vt-password: ENH Replace getters that return valid characters with a function. #114

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Many Rules return a method that contains for instance valid characters. This 
works well for Roman alphabet based systems but fails for other cultures.

NumericalSequenceRule 
=====================
THinks that only 0 thru 9 are digits. Unicode i believe contains other digits 
which means this rule would be broken for them. I would suggest that one 
returns something that uses Character.isDigit.

AlphabeticalSequenceRule
========================
ASR it uses two arrays containing A-Z which only works for Roman alphabets. I 
would suggest that a system that calculated sequenecs based on unicode and 
lowercasing.

QwertySequenceRule
==================

I like this rule but again it fails as some of keyboards always seem to have 
symbols in different places that are not next to each other.  Pipe seems to be 
a favourite from my past experience that likes to travel each time i get a new 
laptop. Yes its annoying but it would be great to be able to not assume PIPE is 
in a set place on all keyboards.

Perhaps a function that took two chars and returned true if they are next to 
each other might help with numerous constants.

interface AdjacentKeyboardKey {
  boolean isAdjacent( char first, char second );
}

QWERTY // detects all letter sequences on a QWERTY keyword
NUMBERS // detects all digits above qwerty including shifted versions.
AND( AKK, AKK )// chains two AKK together...

Original issue reported on code.google.com by miroslav...@gmail.com on 17 Jun 2011 at 9:34

GoogleCodeExporter commented 8 years ago
This library was written without support for internationalization. Please 
submit a patch for your particular language and we'll review what refactoring 
needs to occur in order to make internationalization easier. Thanks.

Original comment by dfis...@gmail.com on 20 Jun 2011 at 5:49

GoogleCodeExporter commented 8 years ago
Internationalization will be a primary feature of the next major release.

Original comment by dfis...@gmail.com on 24 Apr 2013 at 9:07