ramakrishnach04 / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

vt-ldap: review provider framework #116

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Review the provider and provider.jndi packages.
Of specific concern is property duplication and ease of extensibility.

The current class model looks like: Provider -> ConnectionFactory -> Connection 
-> SearchIterator
You'll notice that many properties on the Provider make their way all the way 
down to the SearchIterator. In order to customize some implementation in the 
SearchIterator, you'd have to implement or extend these 4 classes. That seems 
like too high of a hurdle for simple search changes.

Original issue reported on code.google.com by dfis...@gmail.com on 26 Jul 2011 at 4:44

GoogleCodeExporter commented 8 years ago

Original comment by dfis...@gmail.com on 26 Jul 2011 at 4:45

GoogleCodeExporter commented 8 years ago
Beginning code review.

Original comment by marvin.addison@gmail.com on 22 Aug 2011 at 5:23

GoogleCodeExporter commented 8 years ago
Made some progress on this refactoring in r2096.

Original comment by dfis...@gmail.com on 29 Aug 2011 at 3:12

GoogleCodeExporter commented 8 years ago
Made some comments on r2098 commit.

Original comment by marvin.addison@gmail.com on 13 Sep 2011 at 7:26

GoogleCodeExporter commented 8 years ago

Original comment by marvin.addison@gmail.com on 7 Nov 2011 at 6:12