search

raman-noodles / Raman-noodles

Repository containing code for analysis of Raman and IR spectra datasets
MIT License
26 stars 10 forks source link

Possible Improvement - Shoyu.py CAS # Checking #6

Closed JonathanOnorato closed 5 years ago

JonathanOnorato commented 5 years ago

A possible improvement would be to modify Shoyu.py to check to see if the passed CAS # is an int or a string first, before attempting to parse it. If you don't do this, and CAS # is passed as an int, we get a attribute error, as the system is attempting to split it at the "-" character, a feature that ints do not have. Should be a relatively quick fix, but would be a nice QOL change.

JonathanOnorato commented 5 years ago

This issue will not be resolved, as it applies only to the functionality that relates to the NIST Infrared Spectroscopy database, and so it is not going to continue to be used when we switch to purely Raman data.