search

raman325 / broadlink-rm-rest

Python based REST server to interact with Broadlink RM IR/RF blasters
MIT License
12 stars 5 forks source link

Update blaster_db.py #9

Open Coday-meric opened 3 years ago

Coday-meric commented 3 years ago

Blasters support RM4, RM4c, RM4 Pro and some RM3 blasters. Use rm4 class and get_type function.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.45%.

Quality metrics Before After Change
Complexity 3.91 ⭐ 4.03 ⭐ 0.12 👎
Method Length 27.76 ⭐ 29.19 ⭐ 1.43 👎
Working memory 7.00 🙂 7.50 🙂 0.50 👎
Quality 80.41% ⭐ 78.96% ⭐ -1.45% 👎
Other metrics Before After Change
Lines 160 166 6
Changed files Quality Before Quality After Quality Change
app/db_helpers/blaster_db.py 80.41% ⭐ 78.96% ⭐ -1.45% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
app/db_helpers/blaster_db.py get_new_blasters 5 ⭐ 112 🙂 14 😞 55.83% 🙂 Extract out complex expressions
app/db_helpers/blaster_db.py Blaster.device 3 ⭐ 73 🙂 11 😞 68.01% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.