Segment fault when open port failed

[GoogleCodeExporter]

What steps will reproduce the problem?
1.when drone open NFLOG (Linux netfilter log interface) failed, segment fault 
occur.

What version and revision of the product are you using (available in the
About dialog)? On what operating system?
ostinato version is 0.5, OS is arch linux, libpcap verison is 1.2.1

Please provide any additional information below.

in source file 'server/pcapport.cpp, Line 196',
when drone failed to open port, handle_ is set to NULL
in source file 'server/linuxport.cpp, Line 43,44', monitorRX_ & monitorTX_ is 
deleted. so 'PcapPort::PortMonitor::~PortMonitor()' be called, and execute 
'pcap_close(handle_)'. This is the cause of segment fault occur.

I change file 'server/pcapport.cpp, Line 255', from
    pcap_close(handle_);
to
    if (handle_ != NULL)
        pcap_close(handle_);

Now it worked. Is this a bug?

Attachmemt is patch file.

Original issue reported on code.google.com by printf...@gmail.com on 3 Mar 2012 at 5:59

Attachments:

• open-port-error.patch

[GoogleCodeExporter]

Yes, this is a bug. 

I appreciate your investigating the cause of the segfault and sending a patch 
for the same - Thank You! I'll apply it to the tree shortly.

Original comment by pstav...@gmail.com on 7 Mar 2012 at 1:53

• Changed state: Accepted

[GoogleCodeExporter]

This issue was closed by revision 8c8344aac8eb.

Original comment by pstav...@gmail.com on 7 Mar 2012 at 1:55

• Changed state: Fixed

[GoogleCodeExporter]

Issue 65 has been merged into this issue.

Original comment by pstav...@gmail.com on 9 Mar 2012 at 2:00

[GoogleCodeExporter]

Issue 65 has been merged into this issue.

Original comment by pstav...@gmail.com on 18 May 2014 at 5:31