search

raman325 / pytomorrowio

Async Python client for Tomorrow.io API
MIT License
2 stars 3 forks source link

Track daily max request limit using response header #4

Closed raman325 closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #4 (e01f025) into master (3618c6c) will decrease coverage by 0.70%. The diff coverage is 23.52%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   71.16%   70.46%   -0.71%     
==========================================
  Files           7        7              
  Lines         274      281       +7     
==========================================
+ Hits          195      198       +3     
- Misses         79       83       +4
Impacted Files Coverage Δ
pytomorrowio/pytomorrowio.py 54.14% <18.75%> (-0.83%) :arrow_down:
pytomorrowio/const.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3618c6c...e01f025. Read the comment docs.

lymanepp commented 2 years ago

Thanks for cleaning up some of my changes. I'm done reviewing.

lymanepp commented 2 years ago

Fyi, I left a few comments on this PR that weren't addressed--one of which is a bug.

raman325 commented 2 years ago

where did you leave the comments? I didn't see any here

lymanepp commented 2 years ago

where did you leave the comments? I didn't see any here

I submitted https://github.com/raman325/pytomorrowio/pull/9 to address my comments.