Can't compile; framesync.h error

[Roy12321334]

In file included from C:\Users\me\Documents\Arduino\gbs-control\gbs-control.ino:20: C:\Users\me\Documents\Arduino\gbs-control\framesync.h: In static member function 'static bool FrameSyncManager<GBS, Attrs>::findBestHTotal(uint32_t&)': framesync.h:148:33: error: call of overloaded 'abs(uint32_t)' is ambiguous 148 | if (abs(inPeriod - outPeriod) <= 4) { | ^

[gingerbeardman]

That line of code was last modified 17 months ago, so I think it's possible to compile or inability to do so would have been spotted by now.

https://github.com/ramapcsx2/gbs-control/blame/b9265e4025730aff7e0a4dbb82ac862eb9ba1b6a/framesync.h#L148

Please check your compilation method.

[godzivan]

Roy12321334 he is right, as reported on the arduino site: https://www.arduino.cc/reference/en/language/functions/math/abs/

this is the fix :

int32_t ttemp;
// allow ~4 negative (inPeriod is < outPeriod) clock cycles jitter 
ttemp=inPeriod - outPeriod;
if (abs(ttemp) <= 4) {
//if (abs(inPeriod - outPeriod) <= 4) {

[TioChico27]

I got that same error yesterday. Try to use the Esp8266 version 2.7.4 library insted of 3.0.0, this resolved the issue here.

[godzivan]

it's still a bug, my solution is correct

[gingerbeardman]

Thanks @godzivan could you please submit a PR with the fix?