ramapcsx2 / gbs-control

GNU General Public License v3.0
788 stars 110 forks source link

Diagonal lines #262

Open bmarvo opened 3 years ago

bmarvo commented 3 years ago

I'm getting prominent diagonal lines in my image. This happens with every console I try. I also used several different power supplies. I'm currently using this one: Triad Magnetics WSU050-3000

I've also performed all applicable mods.

Here's a capture of what I'm seeing (N64): gbsc_diagonal_lines

I saw an issue someone made regarding diagonal lines in their ps2 output. It was suggested that they tried a different power supply. I did some troubleshooting, checking the output of my psu on a scope and trying more aggressive filtering. Nothing has had an effect on the diagonal lines unfortunately.

Another note, if I enable developer mode and increase/decrease HTotal, the angle of the diagonal lines changes (for what it's worth)

ramapcsx2 commented 3 years ago

Noise gets into the system, and due to it trying to synchronize source and output, the noise becomes a visible pattern like this. It can be hard to even find the cause of such noise, but make sure you try different video cables and if you're capturing, also check the output on a TV.

Mr12mill commented 5 months ago

I fixed this on my unit that had lines only in 480p output by adding the time of one frame to the output framerate reading before syncing. Only works with external clock generator installed. This fix is for 480p output (0x04)

In gbs-control.ino you will find the externalClockGenSyncInOutRate function. void externalClockGenSyncInOutRate()

Go down to the lines that says:

float ofr = getOutputFrameRate();
if (ofr < 47.0f || ofr > 86.0) {

And insert two lines of code between as this:

float ofr = getOutputFrameRate();

if (rto->presetID == 0x04 && uopt->enableFrameTimeLock == 0)
    ofr = ofr + (1 / ofr);

if (ofr < 47.0f || ofr > 86.0) {

Hope this helps someone

EDIT: This doesn't play nice with FrameTimeLock, so now the code checks for that. Also removed comments from code.

Mr12mill commented 5 months ago

164 looks like the same issue, but it is closed

275 might be the same