search

ramapcsx2 / gbs-control

GNU General Public License v3.0
775 stars 110 forks source link

move all headers with byte buffers into `presets` #378

Open israpps opened 1 year ago

ramapcsx2 commented 1 year ago

Hey, are you planning any more restructuring things? I just wonder whether to merge each such PR, or we bunch them up to a package :)

israpps commented 1 year ago

Hey, are you planning any more restructuring things? I just wonder whether to merge each such PR, or we bunch them up to a package :)

Hi!

Not sure tbh

I do the PRs as I delve more into this project...

This PR was an idea I got after uploading the sketch into my esp8266

israpps commented 1 year ago

Hey, are you planning any more restructuring things? I just wonder whether to merge each such PR, or we bunch them up to a package :)

Hi!

Not sure tbh

I do the PRs as I delve more into this project...

This PR was an idea I got after uploading the sketch into my esp8266

Although, keeping structural changes separated in their own commits seems like a sane idea for the git history.

So maybe 1 PR per large change?

So you can use squash and merge to keep all related changes in one commit

ramapcsx2 commented 1 year ago

Well, I can say that the history for this project is not that important. It's super messy already, and anything of value is already buried deep within multiple way too large code change commits.

So on that note, I'm good with however you wanna tackle it. If you need anything merged, please just say so in the merge comment, and I'll do it right away :)